refactor: Error cleanup #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't send a special error if sending to an expected pipe fails
irpc will already produce an io error BrokenPipe, which is more informative than just "error"
- don't use other("...") for unsupported ops
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/202/docs/iroh_blobs/ Last updated: 2025-12-04T14:10:17Z |
dignifiedquire
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Note: we might replace the probably overused io::Error and replace it with an enum done via n0_error. But that is a can of worms because it would require serializing n0_error error chains...
Change checklist